Add e2e repro test and seqno log assertion for joining node with corrupted (truncated) ledger file#7666
Merged
Merged
Conversation
Co-authored-by: achamayou <[email protected]>
Copilot
AI
changed the title
[WIP] Add testcase for issue flagged in #6612
Add e2e test for joining node with corrupted (truncated) ledger file
Feb 13, 2026
achamayou
reviewed
Feb 13, 2026
…itions Co-authored-by: achamayou <[email protected]>
Member
|
Note that this is only a repro (not a fix) for #6612. |
eddyashton
reviewed
Feb 17, 2026
Co-authored-by: eddyashton <[email protected]>
eddyashton
approved these changes
Feb 18, 2026
Copilot
AI
changed the title
Add e2e test for joining node with corrupted (truncated) ledger file
Add e2e repro test and txid log assertion for joining node with corrupted (truncated) ledger file
Jun 9, 2026
Member
|
@copilot fix the code formatting |
Contributor
Author
achamayou
reviewed
Jun 10, 2026
Copilot
AI
changed the title
Add e2e repro test and txid log assertion for joining node with corrupted (truncated) ledger file
Add e2e repro test and seqno log assertion for joining node with corrupted (truncated) ledger file
Jun 10, 2026
Co-authored-by: achamayou <[email protected]>
achamayou
approved these changes
Jun 11, 2026
cjen1-msft
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces issue #6612 when a node joins from a recent snapshot with an older corrupted or truncated uncommitted ledger file, and asserts that the malformed-ledger path is exercised.
The change adds
test_add_node_with_corrupted_ledgertotests/reconfiguration.py, includes it in both the reconfiguration suite and the explicitrun_alle2e flow, and makes the test fail if it cannot find a chunk or transaction to corrupt.It also updates incomplete-ledger recovery logging in
src/host/ledger.hso the malformed entry is reported at the corresponding seqno, and tightens the test to require that specific malformed-ledger log line for the targeted seqno.The PR includes the related formatting follow-up and was validated with targeted checks plus code review and CodeQL.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.